Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support time_to_sec pushdown to tiflash #35739

Merged
merged 12 commits into from
Jul 8, 2022
Merged

expression: support time_to_sec pushdown to tiflash #35739

merged 12 commits into from
Jul 8, 2022

Conversation

hey-kong
Copy link
Contributor

@hey-kong hey-kong commented Jun 26, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35900
Related Issue: pingcap/tiflash#5116

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support function time_to_sec pushdown to tiflash.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 26, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@hey-kong hey-kong changed the title support time_to_sec pushdown to tiflash expression: support time_to_sec pushdown to tiflash Jun 26, 2022
@hey-kong
Copy link
Contributor Author

/run-check_title

@sre-bot
Copy link
Contributor

sre-bot commented Jun 26, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/82fa369ab21dcfd5825fafabf87f5a3ed749f70d

@hey-kong hey-kong mentioned this pull request Jun 29, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2022
zanmato1984
zanmato1984 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 4, 2022
bestwoody
bestwoody approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@bestwoody bestwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@bestwoody: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zanmato1984
Copy link
Contributor

@hey-kong Seems the failing unit test has something to do with your code. Please try fixing it.

The error is here: https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb_ghpr_unit_test/runs/56928/nodes/59/steps/64/log/?start=0

Search for keyword TestTimeToSecPushDownToTiFlash.

@zanmato1984 zanmato1984 mentioned this pull request Jul 6, 2022
Merged
12 tasks
@zanmato1984
Copy link
Contributor

/run-all-tests

@zanmato1984
Copy link
Contributor

@hey-kong Seems the UT is still breaking the same way. Could you please take a look? Thanks.

@hey-kong
Copy link
Contributor Author

hey-kong commented Jul 6, 2022

@hey-kong Seems the UT is still breaking the same way. Could you please take a look? Thanks.

I'm not sure exactly how integration tests are executed, maybe pingcap/tiflash#5235 should be merged first

@zanmato1984
Copy link
Contributor

@hey-kong Seems the UT is still breaking the same way. Could you please take a look? Thanks.

I'm not sure exactly how integration tests are executed, maybe pingcap/tiflash#5235 should be merged first

OK, I'll take a deep look and come back to you.

@ywqzzy
Copy link
Contributor

ywqzzy commented Jul 7, 2022

@hey-kong Seems the UT is still breaking the same way. Could you please take a look? Thanks.

I'm not sure exactly how integration tests are executed, maybe pingcap/tiflash#5235 should be merged first

Can you pass the integration test locally？If yes, could you tell me how to make the test pass? Thank you

@hey-kong @ywqzzy
Update planner/core/integration_test.go
9ffe450 
Co-authored-by: yanweiqi <592838129@qq.com>
@zanmato1984
Copy link
Contributor

/run-all-tests

@zanmato1984 @ywqzzy
Update planner/core/integration_test.go
734cb1c 
Co-authored-by: yanweiqi <592838129@qq.com>
@zanmato1984
Copy link
Contributor

/rebuild

@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2cb5e97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2022
@zanmato1984
Copy link
Contributor

/run-mysql-test

@zanmato1984
Copy link
Contributor

/run-check-license

@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@hey-kong: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1a5919f into pingcap:master Jul 8, 2022
@hey-kong hey-kong deleted the pushdown branch July 11, 2022 02:30
@SeaRise SeaRise mentioned this pull request Jul 11, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy left review comments

@bestwoody bestwoody bestwoody approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TimeToSec function pushdown
7 participants
@hey-kong @ti-chi-bot @sre-bot @zanmato1984 @ywqzzy @guo-shaoge @bestwoody