-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: let TypeFloat should be decoded as Float32 in Chunk (#35978) #36096
util: let TypeFloat should be decoded as Float32 in Chunk (#35978) #36096
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@Yisaer you're already a collaborator in bot's repo. |
Signed-off-by: yisaer <disxiaofei@163.com>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/878b5fc93f12f0c452bea4dbafeee6d3fc5ba5af |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1b3fe86
|
cherry-pick #35978 to release-6.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36096
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #35910
Problem Summary:
In
fieldType2Flag
, bothTypeFloat
andTypeDouble
will set datum flag asFloatFlag
. However,TypeFloat
will addFloat32
in chunk while we directlyGetFloat64
inDecodeOne
function, which caused out of range error.What is changed and how it works?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.