Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: restore privilege tables on full restore by default #36227

Closed
wants to merge 24 commits into from

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #35395

Problem Summary:

What is changed and how it works?

  • restore full and restore point with full backup data which contains system tables(i.e. backup data since 5.1.0) can only run on a fresh and system-table-compatible cluster by default. if user want old behavior and only restore data, user can set filter explicitly.
  • if the backup data doesn't contain system tables, we use old behavior, there's no fresh cluster check and only restores data.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

restore privilege tables on full restore by default

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 15, 2022
@lance6716
Copy link
Contributor Author

/cc @D3Hunter

@ti-chi-bot ti-chi-bot requested a review from D3Hunter July 15, 2022 03:54
@lance6716 lance6716 closed this Jul 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 15, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: restore privilege tables on full restore by default
4 participants