Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: avoid change the type of the input of sum/avg #36372

Merged
merged 12 commits into from
Jul 29, 2022
Merged

planner: avoid change the type of the input of sum/avg #36372

merged 12 commits into from
Jul 29, 2022

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Jul 20, 2022 •
edited
Loading

Signed-off-by: xufei xufeixw@mail.ustc.edu.cn

What problem does this PR solve?

Issue Number: close #36371

Problem Summary:

What is changed and how it works?

In #7860, it saved the return type of sum/avg to its input argument, this is actually a workaround as the review comments shows:

Screen Shot 2022-07-20 at 5 45 37 PM

The only reason to do so is that baseAvgDecimal does not have the return type, however, after #30010, baseAvgDecimal do have the return type information, so we can use the return type information directly, and it makes no sense to save the return type in the input argument anymore.

This pr remove the related codes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2022
@windtalker windtalker changed the title [DNM] avoid change the type of the input of sum/avg [DNM] planner: avoid change the type of the input of sum/avg Jul 20, 2022
@XuHuaiyu
Copy link
Contributor

/run-integration-common-test
/run-common-test
/run-sqllogic-test
/run-mybatis-test
/run-tics-test

@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2022
@XuHuaiyu
Copy link
Contributor

/run-mysql-test tidb-test=pr/1895

1 similar comment
@windtalker
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1895

@windtalker
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2022
@windtalker
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1895

@windtalker
Copy link
Contributor Author

/run-integration-common-test
/run-common-test
/run-sqllogic-test
/run-mybatis-test
/run-tics-test

@windtalker windtalker force-pushed the agg_refine branch 2 times, most recently from a6a020e to 31de0d3 Compare July 22, 2022 04:35
@windtalker
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jul 22, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/df95a77b35d9ae7b9c3ef55d45292399fa6819e3

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@windtalker
avoid change the type of the input of sum/avg
5df919a 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix tests in explain_test
de4372e 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix ci
0cdb51f 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
update tests
d716899 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix ci
2430d48 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix ci
2176290 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix ci
b4038ed 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix ut
3813b8c 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker windtalker changed the title [DNM] planner: avoid change the type of the input of sum/avg planner: avoid change the type of the input of sum/avg Jul 29, 2022
@windtalker
Copy link
Contributor Author

Also need to update the test reference in tidb-test repo: https://github.com/pingcap/tidb-test/pull/1895

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2022
@windtalker
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3813b8c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022
@windtalker
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1895

@ti-chi-bot ti-chi-bot merged commit f459bb3 into pingcap:master Jul 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 2, success 9, total 11 16 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 9, success 8, total 17 18 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 33 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 12 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 11 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 43 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 3 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 16 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@windtalker windtalker deleted the agg_refine branch October 23, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The planner should not change the type of the input for sum/avg
5 participants
@windtalker @ti-chi-bot @XuHuaiyu @sre-bot @wshwsh12