*: use goroutine pool to avoid runtime.morestack #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
force-pushed
the
tiancaiamao/morestack
branch
from
23c762e to
ae70f39
Compare
tiancaiamao
force-pushed
the
tiancaiamao/morestack
branch
from
ae70f39 to
a636621
Compare
|
@tiancaiamao |
I'll fix it in make leak
tiancaiamao
changed the title
tiancaiamao
changed the base branch from
tiancaiamao/goroutine-pool
to
master
|
@tiancaiamao |
winkyao
reviewed
Sep 21, 2017
| @@ -43,6 +44,8 @@ const ( | |||
| minLogDuration = 50 * time.Millisecond | |||
| ) | |||
|
|
|||
| var xIndexSelectGP = gp.New(3 * time.Minute) | |||
There was a problem hiding this comment.
why use diffrent idleTimeout?
There was a problem hiding this comment.
It doesn't matter whether it 2mins or 3mins or anything.
| reserveStack(false) | ||
| for _, batch1 := range batches { | ||
|
|
||
| batch := batch1 |
There was a problem hiding this comment.
That's a good habit ! @winkyao
When using closure along with range operation, it's easy to get suck:
arr := []int{1, 2, 3, 4}
for _, v := range arr {
go func() {
fmt.Println(v) // guess the result?
}()
}
|
/run-all-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this branch works, you can have a try. @siddontang