Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: push down bin function to tiflash #37589

Merged
merged 3 commits into from
Sep 26, 2022
Merged

expression: push down bin function to tiflash #37589

merged 3 commits into from
Sep 26, 2022

Conversation

An-DJ
Copy link
Contributor

@An-DJ An-DJ commented Sep 3, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #37588

Problem Summary:

What is changed and how it works?

Implement bin function push down to TiFlash.
The Bin in TiFlash has been implemented by TiFlash#5246

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Push down bin function to tiflash.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 3, 2022
@An-DJ
Copy link
Contributor Author

An-DJ commented Sep 7, 2022

/cc @ywqzzy

@ti-chi-bot ti-chi-bot requested a review from ywqzzy September 7, 2022 01:14
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2022
@mengxin9014
Copy link
Contributor

Adding unit tests might be even better.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2022
mengxin9014
mengxin9014 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@mengxin9014 mengxin9014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@mengxin9014: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@An-DJ
Copy link
Contributor Author

An-DJ commented Sep 12, 2022

/assign @guo-shaoge

@windtalker
Copy link
Contributor

/merge

1 similar comment
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0cad943

1 similar comment
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0cad943

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. labels Sep 26, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Sep 26, 2022

/rebuild

@ti-chi-bot ti-chi-bot merged commit 3fa7534 into pingcap:master Sep 26, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/tics-test ✅ all 1 tests passed 11 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 32 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 24 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 30 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 4 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 10 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@An-DJ An-DJ mentioned this pull request Oct 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@SeaRise SeaRise SeaRise approved these changes

@mengxin9014 mengxin9014 mengxin9014 approved these changes

@ywqzzy ywqzzy Awaiting requested review from ywqzzy

Assignees

@guo-shaoge guo-shaoge

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement bin function push down to TiFlash
9 participants
@An-DJ @ti-chi-bot @mengxin9014 @windtalker @XuHuaiyu @SeaRise @sre-bot @LittleFall @guo-shaoge