Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: supports create/alter/drop resource group #39546

Merged
merged 8 commits into from
Dec 5, 2022
Merged

parser: supports create/alter/drop resource group #39546

merged 8 commits into from
Dec 5, 2022

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Dec 1, 2022

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Issue Number: Ref #38825

Problem Summary:
The Spec show details: https://docs.google.com/document/d/1P_D1R1qGMFjmjbGCxYjRodgp1Yeyx4dBvg2W1l_Eiy0/edit?n=1-page_Spec_template#

What is changed and how it works?

add parser part only.

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BornChanger
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2022
@nolouch
parser: supports create/alter/drop resource group
34c1ed2 
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
try to fix test
5513be6 
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
nolouch
nolouch commented Dec 2, 2022
View reviewed changes
parser/parser.y Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
tiancaiamao
tiancaiamao reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does OR REPLACE

parser/parser.y Outdated Show resolved Hide resolved
@nolouch
address comments
722104e 
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Merge remote-tracking branch 'origin/master' into add-resource-group
7db22b5 
Conflicts:
	parser/parser.go
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 5, 2022
BornChanger
BornChanger requested changes Dec 5, 2022
View reviewed changes
parser/parser.y
{
$$ = &ast.ResourceGroupOption{Tp: ast.ResourceWRURate, StrValue: $3}
}
| "CPU" EqOpt stringLit
Copy link
Contributor

@BornChanger BornChanger Dec 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we can say "create resource group x rru_per_sec='2000', cpu = '8'". That is specify rru_per_sec and cpu at the same time? The semantic is a little weird. I prefer to make 2 option groups, either rru&wru or cpu/iobandwidth.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here only parser part. we can limit the behavior in DDL handle logic. ru and cpu/bandwith cannot be specified at the same time, report the error to user.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 5, 2022
@nolouch
fix test
c8ffa39 
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 5, 2022
BornChanger
BornChanger approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 5, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 5, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b9c897f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@ti-chi-bot ti-chi-bot merged commit 7af9eb6 into pingcap:master Dec 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 5 min 37 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 2, success 38, total 40 25 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 0 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 36 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 17 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 0 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 50 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@nolouch nolouch deleted the add-resource-group branch December 5, 2022 20:09
@nolouch nolouch mentioned this pull request Dec 22, 2022
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nolouch @ti-chi-bot @tiancaiamao @sre-bot @BornChanger