Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: add info schema cache and ttl table status table cache for ttl scheduler (#39467) #39628

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39467

What problem does this PR solve?

Issue Number: close #39466

Problem Summary:

To implement a ttl job scheduler, we'll need a local map for info schema and ttl table status, to map from a physical table id to related schema information and the information stored in the ttl table status

What is changed and how it works?

It does the following changes:

  1. Refine the code structure. The sql generator and cache are split and placed in different directories. If we are using sql generator and cache from the manager, both placing them in one level and "reverse (about the folder hierarchy) dependency" is not suggested.
  2. Move codes related with session into ttl/session, and add an interface of session pool into it (though there are some existing session pool, with the same definition here). I don't know whether it appropriate to add yet another session pool interface (but others are in extensions, br... pkg).
  3. Add two struct: InfoSchemaCache and the TTLTableStatusCache. They are the local mirror of the info schema and mysql.tidb_ttl_table_status system table.

This PR relies on #39315. Please merge it before this one.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 5, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved affects-6.5 This bug affects the 6.5.x(LTS) versions. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 5, 2022
@YangKeao YangKeao mentioned this pull request Dec 16, 2022
60 tasks
@bb7133
Copy link
Member

bb7133 commented Dec 19, 2022

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 19, 2022
@YangKeao
Copy link
Member

TestTTLStatusCache failed in https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_unit_test/detail/ghpr_unit_test/9258/pipeline

@YangKeao PTAL

It would be fixed automatically after #39619 is merged 🤔

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2022
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2022
@bb7133
Copy link
Member

bb7133 commented Dec 20, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 46a2d47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@ti-chi-bot ti-chi-bot merged commit 03b6d04 into pingcap:release-6.5 Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants