Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Support Failed-Login Tracking and Temporary Account Locking (#39322) #39846

Merged
merged 7 commits into from
Dec 14, 2022
Merged

*: Support Failed-Login Tracking and Temporary Account Locking (#39322) #39846

merged 7 commits into from
Dec 14, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39322

What problem does this PR solve?

Issue Number: close #38938

Problem Summary:

What is changed and how it works?

Most of the feature is the same as MySQL's, except that:

  • A server restart, accounts not reset
  • Execution of FLUSH PRIVILEGES. (Starting the server with --skip-grant-tables, failed-login tracking is working.
    In this case, the first execution of FLUSH PRIVILEGES accounts not reset.)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.


Support failed-login tracking and temporary account locking for users with `FAILED_LOGIN_ATTEMPTS` and/or `PASSWORD_LOCK_TIME`

@lastincisor @ti-chi-bot
This is an automated cherry-pick of pingcap#39322
c1602c3 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot requested a review from a team as a code owner December 12, 2022 14:12
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Dec 12, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 12, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 12, 2022
@lastincisor
Copy link
Contributor

/run-unit-test

@lastincisor
Copy link
Contributor

/run-check_dev_2

@lastincisor
Copy link
Contributor

/run-all-tests

@CbcWestwolf
Copy link
Member

/assign

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 13, 2022
@CbcWestwolf
Copy link
Member

/run-mysql-test tidb-test=pr/2043

@CbcWestwolf
Copy link
Member

/run-all-tests

1 similar comment
@wuhuizuo
Copy link
Contributor

/run-all-tests

@lastincisor
Copy link
Contributor

/run-mysql-test

@lastincisor
Copy link
Contributor

/run-mysql-test tidb-test=pr/2043

@lastincisor
Copy link
Contributor

/run-unit-test

@lastincisor
Copy link
Contributor

/run-mysql-test tidb-test=pr/2043

@CbcWestwolf
Copy link
Member

/run-mysql-test tidb-test=pr/2043

1 similar comment
@keeplearning20221
Copy link
Contributor

/run-mysql-test tidb-test=pr/2043

@CbcWestwolf
Copy link
Member

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2022
@keeplearning20221
Copy link
Contributor

/run-mysql-test tidb-test=pr/2043

bb7133
bb7133 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 14, 2022
@bb7133
Copy link
Member

bb7133 commented Dec 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c5386cc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2022
@ti-chi-bot ti-chi-bot merged commit d2f13a5 into pingcap:release-6.5 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees

@CbcWestwolf CbcWestwolf

@lastincisor lastincisor

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-chi-bot @lastincisor @CbcWestwolf @wuhuizuo @keeplearning20221 @bb7133 @sre-bot