Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: prevent cursor read from being cancelled by GC (#39950) #39990

Merged
merged 2 commits into from
Feb 17, 2023
Merged

*: prevent cursor read from being cancelled by GC (#39950) #39990

merged 2 commits into from
Feb 17, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39950

Signed-off-by: zyguan zhongyangguan@gmail.com

What problem does this PR solve?

Issue Number: close #39447

Problem Summary:

Cursor read might be cancelled by GC since min-start-ts is calculated by min([s.ProcessInfo.CurTxnStartTS for s in all sessions]) however the CurTxnStartTS will be reset once fetch returned.

What is changed and how it works?

  1. Let each session hold a list of pretected timestamps.
  2. Let session manager calculate the min-start-ts (considering protected timestamps).
  3. When start to do cursor read, hold the start-ts until the result set gets close.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zyguan @ti-chi-bot
This is an automated cherry-pick of pingcap#39950
6f772eb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot requested a review from a team as a code owner December 16, 2022 08:15
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 16, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 16, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 16, 2023
@cfzjywxk
Copy link
Contributor

@zyguan
Need help to resolve the conflicts.

@zyguan
resolve the conflict
e14b953 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@cfzjywxk
Copy link
Contributor

@zyguan @ekexium @you06
Need approvements.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e14b953

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2023
@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@zyguan
Copy link
Contributor

zyguan commented Feb 16, 2023

/merge

@zyguan
Copy link
Contributor

zyguan commented Feb 16, 2023

/retest

3 similar comments
@zyguan
Copy link
Contributor

zyguan commented Feb 17, 2023

/retest

@zyguan
Copy link
Contributor

zyguan commented Feb 17, 2023

/retest

@zyguan
Copy link
Contributor

zyguan commented Feb 17, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit 155e3ea into pingcap:release-6.5 Feb 17, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
@YangKeao YangKeao mentioned this pull request Mar 22, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees

@zyguan zyguan

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @cfzjywxk @hawkingrei @zyguan @ekexium @VelocityLight