Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: should set default value gc.ratio-threshold after pitr finished #40141

Merged
merged 4 commits into from
Jan 6, 2023
Merged

log-backup: should set default value gc.ratio-threshold after pitr finished #40141

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acde3bb
should set default value after pitr finished
joccau Dec 23, 2022
fd14c6b
Merge branch 'master' into fix-gc-enable
joccau Dec 27, 2022
88a9d64
Merge branch 'master' into fix-gc-enable
joccau Jan 6, 2023
8c227c1
Merge branch 'master' into fix-gc-enable
ti-chi-bot Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions br/pkg/task/stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,12 @@ func KeepGcDisabled(g glue.Glue, store kv.Storage) (RestoreFunc, error) {
return nil, errors.Trace(err)
}

// If the oldRatio is negative, which is not normal status.
// It should set default value "1.1" after PiTR finished.
if strings.HasPrefix(oldRatio, "-") {
oldRatio = "1.1"
}

return func() error {
return utils.SetGcRatio(execCtx, oldRatio)
}, nil
Expand Down