Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: skip plan-cache for prepared queries with INT in (Decimals...) (#40312) #40691

Merged
merged 4 commits into from
Feb 14, 2023
Merged

planner: skip plan-cache for prepared queries with INT in (Decimals...) (#40312) #40691

merged 4 commits into from
Feb 14, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #40312

What problem does this PR solve?

Issue Number: close #40224

Problem Summary: planner: skip plan-cache for prepared queries with INT in (Decimals...)

What is changed and how it works?

skip plan-cache for prepared queries with INT in (Decimals...)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#40312
e09e9e0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jan 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 18, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added epic/plan-cache sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 18, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 18, 2023
@fzzf678 fzzf678 assigned fzzf678 and unassigned qw4990 Jan 18, 2023
@fzzf678
Copy link
Contributor

fzzf678 commented Jan 19, 2023

/retest

1 similar comment
@fzzf678
Copy link
Contributor

fzzf678 commented Feb 14, 2023

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@qw4990
Copy link
Contributor

qw4990 commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5d7f019

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@fzzf678
Copy link
Contributor

fzzf678 commented Feb 14, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit 07ef435 into pingcap:release-6.5 Feb 14, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees

@fzzf678 fzzf678

Labels
cherry-pick-approved Cherry pick PR approved by release team. epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @fzzf678 @qw4990 @time-and-fate @VelocityLight