Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade go 1.20.1 #40965

Merged
merged 7 commits into from
Feb 20, 2023
Merged

*: upgrade go 1.20.1 #40965

merged 7 commits into from
Feb 20, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 2, 2023 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: ref #40969

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2023
@hawkingrei hawkingrei changed the title *: upgrade 1.20 *: upgrade go 1.20 Feb 2, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test check-dev2

bb7133
bb7133 reviewed Feb 2, 2023
View reviewed changes
parser/terror/terror_test.go Outdated
@@ -142,7 +142,7 @@ func TestTraceAndLocation(t *testing.T) {
sysStack++
}
}
require.Equalf(t, 11, len(lines)-(2*sysStack), "stack =\n%s", stack)
require.Equalf(t, 13, len(lines)-(2*sysStack), "stack =\n%s", stack)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the stack of the error stack? I just curious what the changes look like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use bazel to run tests and bazel will manage Golang environment so that we find the stack path is different from running with gotest.

I have added a comment in the code to describe this problem.

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei changed the title *: upgrade go 1.20 *: upgrade go 1.20.1 Feb 17, 2023
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2023
bb7133
bb7133 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2023
@hawkingrei hawkingrei requested a review from lance6716 February 20, 2023 07:44
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
*: upgrade 1.20
916a354 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade 1.20
09fb0ec 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: bazel upgrade shard_count
a0c15dc 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
9963b4b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
62e316c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2023
hawkingrei
hawkingrei commented Feb 20, 2023
View reviewed changes
util/misc.go Outdated
if inval.Reason != x509.Expired {
return false
}
case *tls.CertificateVerificationError:
Copy link
Member Author

@hawkingrei hawkingrei Feb 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is relation with go1.20.

For a handshake failure due to a certificate verification failure, the TLS
 client and server now return an error of the new type 
CertificateVerificationError, which includes the presented certificates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we use bazel to build/test code with go1.20, we have some tasks with go1.19. I have to skip this test after all upgrading the go1.20

@hawkingrei
update
1575c54 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 20, 2023
@hawkingrei
update
d14e81b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d14e81b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 20, 2023
@ti-chi-bot ti-chi-bot merged commit c987515 into pingcap:master Feb 20, 2023
@hawkingrei hawkingrei deleted the go120release branch February 20, 2023 09:49
you06
you06 reviewed Mar 1, 2023
View reviewed changes
parser/terror/terror_test.go
// ```
//
// So we have to deal with these boundary conditions.
if strings.Contains(line, goroot) || strings.Contains(line, "GOROOT") || strings.Contains(line, "runtime.goexit") {
sysStack++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use gvm and my stack looks like

...
testing.tRunner
        /usr/lib/go/src/testing/testing.go:1576
runtime.goexit
        /usr/lib/go/src/runtime/asm_amd64.s:1598

The last two lines will be counted twice, because /usr/lib/go/src/runtime/asm_amd64.s:1598 also contains goroot, thus make the test fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you06 you06 you06 left review comments

@lance6716 lance6716 lance6716 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hawkingrei @ti-chi-bot @bb7133 @lance6716 @XuHuaiyu @you06