-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: fix panic when nextKey twice (#40959) #41017
lightning: fix panic when nextKey twice (#40959) #41017
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5c74ded
|
/retest |
2 similar comments
/retest |
/retest |
This is an automated cherry-pick of #40959
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: close #40934
Problem Summary:
What is changed and how it works?
Avoid to let CommonHandle++ and decode it because the result may not be a valid value. The string datum encoding will not be ended with 0xff and we may increase 0xfe to 0xff.
tidb/util/codec/bytes.go
Lines 35 to 49 in 151cd7e
Check List
Tests
Run the changed tests and failpoints will trigger this panic. And after the fix it is avoided.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.