statistics/handle: refine the condition of dumping stats delta

[xuyifangreeneyes]

What problem does this PR solve?

Issue Number: ref #38189 ref #36004 ref #39785

Problem Summary:

What is changed and how it works?

Refine the condition of dumping stats delta:

1. If the table doesn't exist or is a mem table or system table, then return false.
2. If the mode is DumpAll, then return true.
3. If the stats delta haven't been dumped in the past hour, then return true.
4. If the table stats is pseudo or empty or Modify Count / Table Count exceeds the threshold.

There are two changes(marked in bold):

1. a mem table or system table: It can prevent the cases such as Continuously update the stats_meta of mysql.tidb in auto analyze loop #39785.
2. pseudo: When we fail to create stats meta after creating a table, ddl, statistics: fix stats meta missing when creating many tables at once #38301 uses the dump stats delta procedure to fill in missing stats meta. However, in that case, the table's stats is pseudo and the old condition would refuse to dump stats delta. So we need the change to fill in missing stats meta completely.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• qw4990
• winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[qw4990]

Can we wrap these lines in a function like:

func (h *Handle) GetInfoSchema() is {
h.mu.Lock()
defer h.mu.Lock()
return h.GetIS().(IS)

[xuyifangreeneyes]

Fixed.

[qw4990]

LGTM

[xuyifangreeneyes]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 87b023b

[xuyifangreeneyes]

/test unit-test

[xuyifangreeneyes]

/test unit-test

[xuyifangreeneyes]

/test check-dev2

[xuyifangreeneyes]

/test unit-test

[xuyifangreeneyes]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 2c59fcb

[ti-chi-bot]

@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #41168.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.3: #41169.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.4: #41170.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #41171.