Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: when pushing topN down below proj, check whether topN.ByItems contains a column(with ID=0) generated by proj (#40593) #41178

Merged
merged 10 commits into from
Aug 17, 2023
Merged

planner: when pushing topN down below proj, check whether topN.ByItems contains a column(with ID=0) generated by proj (#40593) #41178

merged 10 commits into from
Aug 17, 2023

Commits on Feb 8, 2023

  1. the proj below sort will prevent optimizer from pushing the proj down… 

    … to TiDB/TiFlash
    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    b76f793 View commit details
    Browse the repository at this point in the history

  2. add unit test

    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    f948c02 View commit details
    Browse the repository at this point in the history

  3. fix-typo

    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    26a284a View commit details
    Browse the repository at this point in the history

  4. put the test case into the existing file.

    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    33a4fd9 View commit details
    Browse the repository at this point in the history

  5. check whether proj can be eliminated or contains a column in topN.ByI… 

    …tems
    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    3cb0ee0 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary check

    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    b78cc3f View commit details
    Browse the repository at this point in the history

  7. change the code of LogicalProjection.pushDownTopN instead of the Logi… 

    …calSort.pushDownTopN
    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    4f0ce38 View commit details
    Browse the repository at this point in the history

  8. fix: with Column.ID = 0

    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    c3d61bb View commit details
    Browse the repository at this point in the history

  9. check whether the column is generated by projection

    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    3aa0278 View commit details
    Browse the repository at this point in the history

  10. update comment

    @Dousir9 @ti-chi-bot
    Dousir9 authored and ti-chi-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    1a938d5 View commit details
    Browse the repository at this point in the history