Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: enable foreign_key_checks/tidb_enable_foreign_key by default when upgrade #41424

Merged
merged 9 commits into from
Feb 15, 2023
Merged

session: enable foreign_key_checks/tidb_enable_foreign_key by default when upgrade #41424

merged 9 commits into from
Feb 15, 2023

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #41423

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
session: change the global variable foreign_key_checks/tidb_enable_fo…
d9b15e2 
…reign_key value from off to on when upgrade

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 requested a review from a team as a code owner February 15, 2023 05:21
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • you06

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2023
crazycs520
crazycs520 commented Feb 15, 2023
View reviewed changes
session/bootstrap_test.go Outdated Show resolved Hide resolved
@hawkingrei
Copy link
Member

/check-issue-triage-complete

you06 and others added 2 commits February 15, 2023 15:23
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Feb 15, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2023
@tangenta tangenta changed the title session: change the global variable foreign_key_checks/tidb_enable_foreign_key value from off to on when upgrade session: enable foreign_key_checks/tidb_enable_foreign_key by default when upgrade Feb 15, 2023
@crazycs520
Copy link
Contributor Author

/build

@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0cecabf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@crazycs520 crazycs520 added needs-cherry-pick-release-6.6 and removed status/can-merge Indicates a PR has been approved by a committer. labels Feb 15, 2023
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@you06
Copy link
Contributor

you06 commented Feb 15, 2023

/test build

@crazycs520
Copy link
Contributor Author

/merge

@crazycs520 crazycs520 merged commit 98ef95e into pingcap:master Feb 15, 2023
@crazycs520 crazycs520 deleted the fk-bootstrap-change-default branch February 15, 2023 09:14
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #41446.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 15, 2023
@crazycs520 @ti-chi-bot
session: enable foreign_key_checks/tidb_enable_foreign_key by def…
8773bb7 
…ault when upgrade (pingcap#41424)
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@crazycs520 @ghazalfamilyusa
session: enable foreign_key_checks/tidb_enable_foreign_key by def…
c2a7146 
…ault when upgrade (pingcap#41424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@you06 you06 you06 approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

system variables which default value changed should use new default value after upgrade
6 participants
@crazycs520 @ti-chi-bot @hawkingrei @you06 @cfzjywxk @Yisaer