Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: set tidb_server_memory_limit to defValue during bootstrap #41438

Merged
merged 3 commits into from
Feb 16, 2023
Merged

session: set tidb_server_memory_limit to defValue during bootstrap #41438

merged 3 commits into from
Feb 16, 2023

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #41434

Problem Summary:

What is changed and how it works?

Set tidb_server_memory_limit to 80% if the user does not set it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

N/A

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Feb 15, 2023
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner February 15, 2023 07:56
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Feb 15, 2023
@XuHuaiyu XuHuaiyu changed the title session: set tidb_server_memory_limit to 80% during bootstrap session: set tidb_server_memory_limit to defValue during bootstrap Feb 15, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2023
@XuHuaiyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 306fa5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@XuHuaiyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c7e324e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@XuHuaiyu
Copy link
Contributor Author

/retest

@XuHuaiyu XuHuaiyu merged commit d0919b9 into pingcap:master Feb 16, 2023
@XuHuaiyu XuHuaiyu deleted the issue41434 branch February 16, 2023 07:28
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 16, 2023
Merged
4 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41497.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 16, 2023
@XuHuaiyu @ti-chi-bot
This is an automated cherry-pick of pingcap#41438
ef7436a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Feb 21, 2023
@ti-chi-bot
session: set tidb_server_memory_limit to defValue during bootstrap (#…
2150484 
…41438) (#41497)

close #41434
ljun0712 pushed a commit to ljun0712/tidb that referenced this pull request Mar 1, 2023
@ti-chi-bot @wuhuizuo
session: set tidb_server_memory_limit to defValue during bootstrap (p…
e337eed 
…ingcap#41438) (pingcap#41497)

close pingcap#41434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb_server_memory_limit should be set to 80% during bootstrap
5 participants
@XuHuaiyu @ti-chi-bot @qw4990 @wshwsh12 @crazycs520