Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: upgrade client-go dependency, fix compatible issues #41997

Closed
wants to merge 3 commits into from
Closed

client: upgrade client-go dependency, fix compatible issues #41997

wants to merge 3 commits into from

Conversation

cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Mar 7, 2023

What problem does this PR solve?

Issue Number: ref #41203

Problem Summary:
Upgrade the client-go dependency to the latest version and fix compatible issues.

What is changed and how it works?

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2023
@cfzjywxk cfzjywxk requested review from you06, guo-shaoge and zyguan March 7, 2023 15:02
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2023
you06
you06 reviewed Mar 7, 2023
View reviewed changes
store/copr/coprocessor.go Outdated Show resolved Hide resolved
store/copr/mpp.go
@@ -79,7 +70,7 @@ func (c *MPPClient) ConstructMPPTasks(ctx context.Context, req *kv.MPPBuildTasks
tasks, err = buildBatchCopTasksForPartitionedTable(ctx, bo, c.store, rangesForEachPartition, kv.TiFlash, true, ttl, true, 20, partitionIDs)
} else {
if req.KeyRanges == nil {
return c.selectAllTiFlashStore(), nil
return nil, errors.New("KeyRanges in MPPBuildTasksRequest is nil")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it's a different behavior, a request without key ranges is an invalid usage, so returns error is ok, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@purelind
Copy link
Contributor

purelind commented Mar 7, 2023

/retest

@cfzjywxk @you06
Update store/copr/coprocessor.go
dc0c681 
Co-authored-by: you06 <you1474600@gmail.com>
@ti-chi-bot
Copy link
Member

@cfzjywxk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build dc0c681 link true /test build
idc-jenkins-ci-tidb/unit-test dc0c681 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 dc0c681 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2023
@ti-chi-bot
Copy link
Member

@cfzjywxk: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfzjywxk cfzjywxk closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you06 you06 you06 left review comments

@hawkingrei hawkingrei hawkingrei approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

@zyguan zyguan Awaiting requested review from zyguan

Assignees
No one assigned
Labels
component/tikv-client needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cfzjywxk @ti-chi-bot @purelind @hawkingrei @guo-shaoge @you06