Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: display Cardinality info from stats for SHOW INDEX | tidb-test=pr/2107 #42441

Merged
merged 3 commits into from
Apr 10, 2023
Merged

executor: display Cardinality info from stats for SHOW INDEX | tidb-test=pr/2107 #42441

merged 3 commits into from
Apr 10, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented Mar 21, 2023

What problem does this PR solve?

Issue Number: close #42227

Problem Summary:

What is changed and how it works?

we didn't display the NDV information in the SHOW INDEX statement.

This pr intends to add it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2023
@winoros winoros force-pushed the show-ndv-for-show-index branch from 9a01a12 to 8cfc94c Compare March 21, 2023 10:16
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2023
time-and-fate
time-and-fate approved these changes Mar 21, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2023
@hawkingrei
Copy link
Member

/retest

@winoros winoros changed the title executor: display Cardinality info from stats for SHOW INDEX executor: display Cardinality info from stats for SHOW INDEX | tidb-test=pr/2107 Mar 21, 2023
@winoros
Copy link
Member Author

winoros commented Mar 21, 2023

/test mysql-test

@winoros
Copy link
Member Author

winoros commented Mar 21, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cfc94c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2023
@hawkingrei
Copy link
Member

/retest

fixdb
fixdb approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fixdb
Copy link
Contributor

fixdb commented Mar 22, 2023

/retest

4 similar comments
@hawkingrei
Copy link
Member

/retest

@winoros
Copy link
Member Author

winoros commented Mar 22, 2023

/retest

@winoros
Copy link
Member Author

winoros commented Mar 22, 2023

/retest

@winoros
Copy link
Member Author

winoros commented Mar 22, 2023

/retest

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2023
@hawkingrei
Copy link
Member

/test all

@winoros
Copy link
Member Author

winoros commented Apr 10, 2023

/retest

1 similar comment
@winoros
Copy link
Member Author

winoros commented Apr 10, 2023

/retest

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f95e9c0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2023
@ti-chi-bot ti-chi-bot merged commit c233969 into pingcap:master Apr 10, 2023
@winoros winoros deleted the show-ndv-for-show-index branch May 25, 2023 02:56
@winoros winoros mentioned this pull request Jun 18, 2023
Merged
17 tasks
This was referenced Jul 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixdb fixdb fixdb approved these changes

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add index cardinality info in the show index statement
6 participants
@winoros @ti-chi-bot @hawkingrei @fixdb @qw4990 @time-and-fate