Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: refactor for reuse in load data part4 #42727

Merged
merged 15 commits into from
Apr 4, 2023
Merged

lightning: refactor for reuse in load data part4 #42727

merged 15 commits into from
Apr 4, 2023

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #40499

Problem Summary:

What is changed and how it works?

  • separate dupe detect from backend
  • make split data into engines/chunks and local backend independent on lightning config, rename some configs to better reflect its meaning and add comments.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 31, 2023
@D3Hunter D3Hunter requested a review from lance6716 March 31, 2023 07:27
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 31, 2023
@D3Hunter D3Hunter requested a review from GMHDBJD March 31, 2023 07:28
D3Hunter
D3Hunter commented Mar 31, 2023
View reviewed changes
br/pkg/lightning/backend/local/duplicate.go

// CollectLocalDuplicateRows collect duplicate keys from local db. We will store the duplicate keys which
// may be repeated with other keys in local data source.
func (local *DupeController) CollectLocalDuplicateRows(ctx context.Context, tbl table.Table, tableName string, opts *encode.SessionOptions) (hasDupe bool, err error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from local backend

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

2 similar comments
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

@lance6716 @GMHDBJD

lance6716
lance6716 reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 / 28 files viewed

br/pkg/lightning/backend/local/duplicate.go
// NewDuplicateManager creates a new DuplicateManager.
func NewDuplicateManager(
// NewDupeDetector creates a new DupeDetector.
func NewDupeDetector(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also cc @gozssky

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/run-integration-br-test

3 similar comments
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

ci pass
https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_integration_br_test/detail/tidb_ghpr_integration_br_test/12504/pipeline

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/retest

3 similar comments
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/test check_dev_2

@ti-chi-bot
Copy link
Member

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/test check-dev2

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/retest

1 similar comment
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/retest

GMHDBJD
GMHDBJD approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 3, 2023

/retest

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 3, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 4, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b67374e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 4, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 4, 2023

/retest

2 similar comments
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 4, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 4, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit 8f64f36 into master Apr 4, 2023
@ti-chi-bot ti-chi-bot deleted the lit-refactor-part4 branch April 4, 2023 09:56
@ti-chi-bot
Copy link
Member

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test b67374e link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepymole sleepymole sleepymole left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@D3Hunter @ti-chi-bot @lance6716 @sleepymole @GMHDBJD