Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: refactor to reuse in load data part 5 #42856

Merged
merged 9 commits into from
Apr 11, 2023
Merged

lightning: refactor to reuse in load data part 5 #42856

merged 9 commits into from
Apr 11, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Apr 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #40499

Problem Summary:

What is changed and how it works?

  • decouple backend and engine manage code(particially) to use local backend directly in load data
  • remove noop backend. remove LocalEngineWriter wrapper.
  • remove tableName param from writer
  • move some code unique to local backend to itself

Check List

Tests
no code logic change, will use existing ut and Integration test

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code logic change, most change is due to moving and renaming

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 7, 2023
@D3Hunter D3Hunter requested review from lance6716 and GMHDBJD April 7, 2023 07:42
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 7, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 7, 2023

/run-integration-br-test

D3Hunter
D3Hunter commented Apr 7, 2023
View reviewed changes
br/pkg/lightning/backend/backend.go
// ClosedEngine represents a closed engine, allowing ingestion into the target.
// This type is goroutine safe: you can share an instance and execute any method
// anywhere.
type ClosedEngine struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to below where its methods are defined

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 7, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 7, 2023

/run-integration-br-test

3 similar comments
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

ci pass https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_integration_br_test/detail/tidb_ghpr_integration_br_test/12516/pipeline

lance6716
lance6716 reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 / 34 files viewed

br/pkg/lightning/backend/local/disk_quota.go

// CheckDiskQuota verifies if the total engine file size is below the given
// quota. If the quota is exceeded, this method returns an array of engines,
// which after importing can decrease the total size below quota.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we use inProgressLargeEngines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't look in detail, just copied out

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2023
GMHDBJD
GMHDBJD approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2023
@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4f784fd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 11, 2023
@D3Hunter
Copy link
Contributor Author

/retest

3 similar comments
@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot merged commit d250a3f into master Apr 11, 2023
@ti-chi-bot ti-chi-bot deleted the lit-split-backend branch April 11, 2023 04:11
@ti-chi-bot
Copy link
Member

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 4f784fd link unknown /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D3Hunter @ti-chi-bot @lance6716 @GMHDBJD