Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: renew the global resource control rfc #43389

Merged
merged 3 commits into from
Jun 27, 2023
Merged

docs: renew the global resource control rfc #43389

merged 3 commits into from
Jun 27, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Apr 25, 2023

What problem does this PR solve?

Issue Number: ref #38825
Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2023
Connor1996
Connor1996 reviewed Apr 25, 2023
View reviewed changes
docs/design/2022-11-25-global-resource-control.md Show resolved Hide resolved
docs/design/2022-11-25-global-resource-control.md Outdated

The values of the coefficients α,β,γare different between `RRU` and `WRU`, and here require datasets from various tests then regress and fit a solution(values) that best maps the actual resource usage.
The values of the coefficients α,β,γ can be different in different environment, they require datasets from various tests then regress and fit a solution(values) that best maps the actual resource usage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The values of the coefficients α,β,γ can be different in different environment, they require datasets from various tests then regress and fit a solution(values) that best maps the actual resource usage.
The values of the coefficients α,β,γ vary in different environment, they require datasets from various tests then regress and fit a solution(values) that best maps the actual resource usage.

@nolouch
Copy link
Member

nolouch commented May 11, 2023

maybe we can replace the overview picture with:
image

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 13, 2023
nolouch
nolouch reviewed Jun 13, 2023
View reviewed changes
docs/design/2022-11-25-global-resource-control.md
Overview

![global quota control.png](imgs/global-quota-control.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove this overview

Connor1996
Connor1996 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 16, 2023

@Connor1996: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

@nolouch: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nolouch
nolouch reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nolouch
Copy link
Member

nolouch commented Jun 26, 2023

/approve

@nolouch nolouch removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 26, 2023
@glorv
Copy link
Contributor Author

glorv commented Jun 26, 2023

@BornChanger PTAL

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-13 03:08:34.932229506 +0000 UTC m=+55111.346833583: ☑️ agreed by nolouch.
  • 2023-06-27 08:46:07.562014636 +0000 UTC m=+697332.963265075: ☑️ agreed by BornChanger.

@glorv
Copy link
Contributor Author

glorv commented Jun 27, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2023

@glorv: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiprow
Copy link

tiprow bot commented Jun 27, 2023

@glorv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 06d3c21 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@glorv
Copy link
Contributor Author

glorv commented Jun 27, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Connor1996, glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit fe248e5 into pingcap:master Jun 27, 2023
@glorv glorv deleted the resource_ctl branch June 28, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@BornChanger BornChanger BornChanger approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glorv @nolouch @Connor1996 @BornChanger