-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, json: restore cast flag after substitute column in cast (#39997) #44100
planner, json: restore cast flag after substitute column in cast (#39997) #44100
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/retest |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c7dc4f4da3859f6f32d4ac7a7353b35dca949ea8
|
/retest |
1 similar comment
/retest |
Wait for #44233 |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
c7dc4f4
to
65968f9
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 65968f9
|
This is an automated cherry-pick of #39997
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Issue Number: close #39806
Problem Summary:
json functions use a flag
mysql.ParseToJSONFlag
to mark whether thecastStringAsJson
function should try to parse the string as a json, or simply convert the string to a json string. For example, with this flag,abcd
is not a valid json, and will return an error. Without this flag,abcd
will be casted to"abcd"
.What is changed and how it works?
Check List
Tests
Release note