Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: deprecate send-kv-pairs #44463

Merged
merged 1 commit into from
Jun 7, 2023
Merged

lightning: deprecate send-kv-pairs #44463

merged 1 commit into from
Jun 7, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jun 7, 2023

What problem does this PR solve?

Issue Number: ref #43853

Problem Summary:

What is changed and how it works?

  • deprecate send-kv-pairs, user can still set it, but it will take no effect

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

deprecate `send-kv-pairs`, user can still set it, but it will take no effect

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 7, 2023
@ti-chi-bot ti-chi-bot bot requested review from TonsnakeLin and zhongzc June 7, 2023 03:02
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 7, 2023
@D3Hunter D3Hunter removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 7, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jun 7, 2023

/run-integration-br-test

lance6716
lance6716 reviewed Jun 7, 2023
View reviewed changes
br/pkg/lightning/config/config.go
@@ -960,7 +960,7 @@ func NewConfig() *Config {
TikvImporter: TikvImporter{
Backend: "",
MaxKVPairs: 4096,
SendKVPairs: KVWriteBatchCount,
SendKVPairs: 32768,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need to set it to 32768?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old default value, don't take effect now

Copy link
Contributor

@lance6716 lance6716 Jun 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can delete this assignment

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jun 7, 2023

/run-integration-br-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

@niubell: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 7, 2023

/run-integration-br-test

1 similar comment
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jun 7, 2023

/run-integration-br-test

GMHDBJD
GMHDBJD approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716, niubell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-07 03:52:41.249013027 +0000 UTC m=+63053.093647612: ☑️ agreed by lance6716.
  • 2023-06-07 04:40:51.300007493 +0000 UTC m=+65943.144642089: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit bc45bdf into master Jun 7, 2023
@ti-chi-bot ti-chi-bot bot deleted the remove-send-kv-pairs branch June 7, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@niubell niubell niubell approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@TonsnakeLin TonsnakeLin Awaiting requested review from TonsnakeLin

@zhongzc zhongzc Awaiting requested review from zhongzc

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@D3Hunter @wuhuizuo @lance6716 @niubell @GMHDBJD