Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl/ingest: fix checkpoint resume when owner changes several times #44760

Merged
merged 8 commits into from
Jun 21, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 19, 2023

What problem does this PR solve?

Issue Number: close #44619

Problem Summary:

When the owner restarts to check if owner instance address has changed, the partitition ID of the checkpoint record will not be written into the checkpoint manager.

This results in the partition ID not being restored to the global checkpoint when restoring adding index job, and finally missing part of the partition's index records.

What is changed and how it works?

Regardless of whether the owner instance address has changed, always record the partition ID of the checkpoint to the checkpoint manager

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2023
@tangenta
Copy link
Contributor Author

/retest

@Benjamin2037
Copy link
Collaborator

Could you add some brief description about the root cause?

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

@ywqzzy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for @ywqzzy

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-20 06:51:30.845720435 +0000 UTC m=+85656.246970882: ☑️ agreed by wjhuang2016.
  • 2023-06-20 08:33:03.609231523 +0000 UTC m=+91749.010481972: ☑️ agreed by xhebox.

@tangenta
Copy link
Contributor Author

/retest

2 similar comments
@tangenta
Copy link
Contributor Author

/retest

@tangenta
Copy link
Contributor Author

/retest

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, wjhuang2016, xhebox, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tangenta
Copy link
Contributor Author

/retest

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44859.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 21, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@tangenta
Copy link
Contributor Author

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #44863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data index inconsistent after DDL owner change several times (at least twice)
6 participants