-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl/ingest: fix checkpoint resume when owner changes several times #44760
ddl/ingest: fix checkpoint resume when owner changes several times #44760
Conversation
/retest |
Could you add some brief description about the root cause? |
@ywqzzy: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve for @ywqzzy
[LGTM Timeline notifier]Timeline:
|
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, wjhuang2016, xhebox, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #44619
Problem Summary:
When the owner restarts to check if owner instance address has changed, the partitition ID of the checkpoint record will not be written into the checkpoint manager.
This results in the partition ID not being restored to the global checkpoint when restoring adding index job, and finally missing part of the partition's index records.
What is changed and how it works?
Regardless of whether the owner instance address has changed, always record the partition ID of the checkpoint to the checkpoint manager
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.