Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: cherry-pick tidb_opt_fix_control and fix 44855 to v6.1.5 #44968

Merged
merged 4 commits into from
Aug 15, 2023
Merged

*: cherry-pick tidb_opt_fix_control and fix 44855 to v6.1.5 #44968

merged 4 commits into from
Aug 15, 2023

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Jun 26, 2023 •
edited
Loading

Manually cherry-pick #43191 and #44865

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@time-and-fate time-and-fate requested a review from a team as a code owner June 26, 2023 16:12
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2023
@time-and-fate time-and-fate changed the title manual cherry-pick *: [DNM] manual cherry-pick Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 27, 2023
@time-and-fate time-and-fate changed the base branch from release-6.1 to release-6.1-20230811-v6.1.5 August 11, 2023 08:54
@ti-chi-bot ti-chi-bot bot removed do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 11, 2023
@time-and-fate time-and-fate changed the title *: [DNM] manual cherry-pick *: cherry-pick tidb_opt_fix_control and fix 44855 to v6.1.5 Aug 11, 2023
@time-and-fate
Copy link
Member Author

/test check_dev

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

@time-and-fate: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 11, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-6.1-20230811-v6.1.5

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@time-and-fate
Copy link
Member Author

/test check-dev

@time-and-fate
Copy link
Member Author

/test mysql-test

@tiprow
Copy link

tiprow bot commented Aug 11, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-6.1-20230811-v6.1.5

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 11, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-6.1-20230811-v6.1.5

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-11 10:03:35.965196844 +0000 UTC m=+279780.514212831: ☑️ agreed by qw4990.
  • 2023-08-11 10:17:39.065021812 +0000 UTC m=+280623.614037799: ☑️ agreed by hawkingrei.

@time-and-fate
Copy link
Member Author

/test check-dev

@tiprow
Copy link

tiprow bot commented Aug 11, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-6.1-20230811-v6.1.5

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@time-and-fate
Copy link
Member Author

/test check-dev

@time-and-fate
Copy link
Member Author

/test mysql-test

@tiprow
Copy link

tiprow bot commented Aug 14, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-6.1-20230811-v6.1.5

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 14, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-6.1-20230811-v6.1.5

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@time-and-fate
Copy link
Member Author

/test mysql-test

@tiprow
Copy link

tiprow bot commented Aug 15, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-6.1-20230811-v6.1.5

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit bb02592 into pingcap:release-6.1-20230811-v6.1.5 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@time-and-fate @hawkingrei @qw4990