Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, expression: fix TableFullScan caused by extraHandleId not correctly found | tidb-test=pr/2145 (#45139) #45211

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45139

What problem does this PR solve?

Issue Number: close #45036

Problem Summary:
Fix the wrong logic to get extraHandleId. And this part needs further refactoring.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 6, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230425-v6.5.2 labels Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@chrysan chrysan changed the title planner, expression: fix TableFullScan caused by extraHandleId not correctly found (#45139) planner, expression: fix TableFullScan caused by extraHandleId not correctly found | tidb-test=pr/2145 (#45139) Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-06 09:21:24.428810872 +0000 UTC m=+13363.310286820: ☑️ agreed by time-and-fate.
  • 2023-07-06 09:45:44.925845744 +0000 UTC m=+14823.807321691: ☑️ agreed by qw4990.

@chrysan
Copy link
Contributor

chrysan commented Jul 6, 2023

/test build

@chrysan
Copy link
Contributor

chrysan commented Jul 6, 2023

/test unit-test

@chrysan
Copy link
Contributor

chrysan commented Jul 6, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Jul 6, 2023

@chrysan: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Jul 6, 2023

@chrysan: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Jul 6, 2023

@chrysan: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrysan
Copy link
Contributor

chrysan commented Jul 6, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 6, 2023

@chrysan: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 44dfece into pingcap:release-6.5-20230425-v6.5.2 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230425-v6.5.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants