*: upgrade go1.20.7 #45741

hawkingrei · 2023-08-02T01:07:22Z

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

codecov · 2023-08-02T01:27:35Z

Codecov Report

Merging #45741 (6c85dce) into master (1bf82bb) will increase coverage by 0.3147%.
Report is 16 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #45741        +/-   ##
================================================
+ Coverage   73.3396%   73.6544%   +0.3147%     
================================================
  Files          1271       1274         +3     
  Lines        392943     396017      +3074     
================================================
+ Hits         288183     291684      +3501     
+ Misses        86386      86040       -346     
+ Partials      18374      18293        -81

Flag	Coverage Δ
integration	`78.1388% <ø> (?)`
unit	`73.6467% <ø> (+0.3070%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`54.0444% <ø> (ø)`
parser	`85.0359% <ø> (ø)`
br	`52.0235% <ø> (+0.0616%)`	⬆️

dveeden · 2023-08-02T06:37:59Z

Doesn't this conflict with #45634 ?

wuhuizuo · 2023-08-02T07:45:16Z

/review how to make it upgrade automatic by dependabot or renovate?

dveeden · 2023-08-02T07:45:19Z

https://go.dev/doc/devel/release

"go1.20.7 (released 2023-08-01) includes a security fix to the crypto/tls package, as well as bug fixes to the assembler and the compiler. See the Go 1.20.7 milestone on our issue tracker for details."

ti-chi-bot · 2023-08-02T07:45:27Z

@wuhuizuo:
Thank you for the pull request. As a reviewer, I noticed that this pull request is just upgrading the Go version from 1.20.6 to 1.20.7. It is a straightforward change, and the diff seems to be correct.

However, I noticed that the title of the pull request is not following the recommended format. The title should include the package name(s) that are being upgraded. For instance, if you are upgrading multiple packages, you should list them in the title like this: "pkg1, pkg2: upgrade to version x.y.z". If you are upgrading all packages, you should use an asterisk like this: "*: upgrade to version x.y.z".

Regarding your question about automatic upgrades, you can use Dependabot or Renovate to keep your dependencies up-to-date. Both tools can be configured to automatically create pull requests for upgrading your packages.

As for this pull request, I think it looks good, and I don't see any issues with it. I suggest that you update the pull request title to follow the recommended format and merge it if there are no objections.

In response to this:

/review how to make it upgrade automatic by dependabot or renovate?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuhuizuo · 2023-08-02T07:48:22Z

/review how to make it upgrade automatic by renovate, please give me a detail configuration guide to reach it.

ti-chi-bot · 2023-08-02T07:48:32Z

@wuhuizuo:
To configure automatic upgrades using Renovate, follow these steps:

Install Renovate from the GitHub Marketplace.
Configure Renovate by creating a renovate.json file in the root of your repository. Here's an example configuration for Go:

{
  "extends": [
    "config:base",
    ":disableRateLimiting"
  ],
  "packageRules": [
    {
      "packageNames": [
        "^go$"
      ],
      "versioning": "go"
    }
  ]
}

This configuration tells Renovate to look for go packages and use the go versioning strategy to upgrade them. Note that we've disabled rate limiting to allow Renovate to check for updates more frequently.

Once you've created the renovate.json file, commit and push it to the repository.
Renovate will now automatically check for updates to your packages and create pull requests to upgrade them. You can configure Renovate to automatically merge these pull requests or to require manual approval.

With these steps, Renovate will automatically upgrade your go package to version 1.20.7 when it becomes available.

In response to this:

/review how to make it upgrade automatic by renovate, please give me a detail configuration guide to reach it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjonss

Should any of the other go 1.20.* versions be upgraded as well?

Dockerfile:ENV GOLANG_VERSION 1.20.5
Dockerfile.enterprise:ENV GOLANG_VERSION 1.20.5
WORKSPACE:    version = "1.20.6",
WORKSPACE.patchgo:        "darwin_amd64": ("go1.20.5.darwin-amd64.tar.gz", "4524fac6858f8170941bb023d218c4a322a38c6b565d7b83f8a80f525c507079"),
WORKSPACE.patchgo:        "darwin_arm64": ("go1.20.5.darwin-arm64.tar.gz", "9bb1564c241e97d9c254a61136601da8a241e11aaa4ff70e5ad2505c5d1e27d1"),
WORKSPACE.patchgo:        "linux_amd64": ("go1.20.5.linux-amd64.tar.gz", "22ddd3f4fa13b55dbccce1b8d6e86907aaae624f71caaf6524da1f382c055a03"),
WORKSPACE.patchgo:        "linux_arm64": ("go1.20.5.linux-arm64.tar.gz", "b0372223fa83123df4166bcfb7c03a30bea20fa226b8c2a8c53aeb61060800d6"),
WORKSPACE.patchgo:    version = "1.20.5",
br/web/package-lock.json:      "version": "1.20.0",
br/web/package-lock.json:      "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz",
br/web/package-lock.json:      "version": "1.20.0",
br/web/package-lock.json:      "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz",
build/image/base:ENV GOLANG_VERSION 1.20.6
go.sum:google.golang.org/grpc v1.20.1/go.mod h1:10oTOabMzJvdu6/UiuZezV6QK5dSlG84ov/aaiqXj38=
go.sum:google.golang.org/protobuf v1.20.1-0.20200309200217-e05f789c0967/go.mod h1:A+miEFZTKqfCUM6K7xSMQL9OKL/b6hQv+e19PK+JZNE=
parser/terror/terror_test.go:           //   /Users/pingcap/.gvm/gos/go1.20.1/src/testing/testing.go:1576
parser/terror/terror_test.go:           //       /Users/pingcap/.gvm/gos/go1.20.1/src/runtime/asm_arm64.s:1172
tests/globalkilltest/Dockerfile:ENV GOLANG_VERSION 1.20.5
tools/patch-go/Dockerfile:ENV GOLANG_VERSION 1.20.5
tools/patch-go/build.sh:GOVERS=1.20.5

hawkingrei · 2023-08-02T09:02:07Z

Should any of the other go 1.20.* versions be upgraded as well?

Dockerfile:ENV GOLANG_VERSION 1.20.5
Dockerfile.enterprise:ENV GOLANG_VERSION 1.20.5
WORKSPACE:    version = "1.20.6",
WORKSPACE.patchgo:        "darwin_amd64": ("go1.20.5.darwin-amd64.tar.gz", "4524fac6858f8170941bb023d218c4a322a38c6b565d7b83f8a80f525c507079"),
WORKSPACE.patchgo:        "darwin_arm64": ("go1.20.5.darwin-arm64.tar.gz", "9bb1564c241e97d9c254a61136601da8a241e11aaa4ff70e5ad2505c5d1e27d1"),
WORKSPACE.patchgo:        "linux_amd64": ("go1.20.5.linux-amd64.tar.gz", "22ddd3f4fa13b55dbccce1b8d6e86907aaae624f71caaf6524da1f382c055a03"),
WORKSPACE.patchgo:        "linux_arm64": ("go1.20.5.linux-arm64.tar.gz", "b0372223fa83123df4166bcfb7c03a30bea20fa226b8c2a8c53aeb61060800d6"),
WORKSPACE.patchgo:    version = "1.20.5",
br/web/package-lock.json:      "version": "1.20.0",
br/web/package-lock.json:      "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz",
br/web/package-lock.json:      "version": "1.20.0",
br/web/package-lock.json:      "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz",
build/image/base:ENV GOLANG_VERSION 1.20.6
go.sum:google.golang.org/grpc v1.20.1/go.mod h1:10oTOabMzJvdu6/UiuZezV6QK5dSlG84ov/aaiqXj38=
go.sum:google.golang.org/protobuf v1.20.1-0.20200309200217-e05f789c0967/go.mod h1:A+miEFZTKqfCUM6K7xSMQL9OKL/b6hQv+e19PK+JZNE=
parser/terror/terror_test.go:           //   /Users/pingcap/.gvm/gos/go1.20.1/src/testing/testing.go:1576
parser/terror/terror_test.go:           //       /Users/pingcap/.gvm/gos/go1.20.1/src/runtime/asm_arm64.s:1172
tests/globalkilltest/Dockerfile:ENV GOLANG_VERSION 1.20.5
tools/patch-go/Dockerfile:ENV GOLANG_VERSION 1.20.5
tools/patch-go/build.sh:GOVERS=1.20.5

@mjonss This has been a long-standing issue, and I'm thinking about how to consolidate it into one place.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

hawkingrei · 2023-08-02T09:10:33Z

@mjonss I have been updated.

ti-chi-bot · 2023-08-03T12:32:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dveeden,mjonss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-08-03T12:32:19Z

[LGTM Timeline notifier]

Timeline:

2023-08-02 07:43:25.805517373 +0000 UTC m=+257689.747865898: ☑️ agreed by dveeden.
2023-08-03 12:32:18.321265636 +0000 UTC m=+361422.263614168: ☑️ agreed by mjonss.

*: upgrade go1.20.7

0810f86

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2023

hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 2, 2023

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Aug 2, 2023

dveeden approved these changes Aug 2, 2023

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 2, 2023

mjonss reviewed Aug 2, 2023

View reviewed changes

update

6c85dce

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2023

hawkingrei requested a review from bb7133 August 2, 2023 11:46

mjonss approved these changes Aug 3, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 3, 2023

ti-chi-bot bot merged commit 522a008 into pingcap:master Aug 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: upgrade go1.20.7 #45741

*: upgrade go1.20.7 #45741

hawkingrei commented Aug 2, 2023

codecov bot commented Aug 2, 2023 •

edited

Loading

dveeden commented Aug 2, 2023

wuhuizuo commented Aug 2, 2023

dveeden commented Aug 2, 2023

ti-chi-bot bot commented Aug 2, 2023

wuhuizuo commented Aug 2, 2023

ti-chi-bot bot commented Aug 2, 2023

mjonss left a comment

hawkingrei commented Aug 2, 2023

hawkingrei commented Aug 2, 2023

ti-chi-bot bot commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

*: upgrade go1.20.7 #45741

*: upgrade go1.20.7 #45741

Conversation

hawkingrei commented Aug 2, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

codecov bot commented Aug 2, 2023 • edited Loading

Codecov Report

dveeden commented Aug 2, 2023

wuhuizuo commented Aug 2, 2023

dveeden commented Aug 2, 2023

ti-chi-bot bot commented Aug 2, 2023

wuhuizuo commented Aug 2, 2023

ti-chi-bot bot commented Aug 2, 2023

mjonss left a comment

Choose a reason for hiding this comment

hawkingrei commented Aug 2, 2023

hawkingrei commented Aug 2, 2023

ti-chi-bot bot commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

[LGTM Timeline notifier]

codecov bot commented Aug 2, 2023 •

edited

Loading