Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: faster adminpause test #45837

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

hawkingrei
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2023
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2023
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #45837 (23869b9) into master (7ef6db2) will increase coverage by 2.3912%.
Report is 235 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45837        +/-   ##
================================================
+ Coverage   73.3700%   75.7612%   +2.3912%     
================================================
  Files          1272       1342        +70     
  Lines        393072     435740     +42668     
================================================
+ Hits         288397     330122     +41725     
- Misses        86312      87478      +1166     
+ Partials      18363      18140       -223     
Flag Coverage Δ
integration 27.1904% <ø> (?)
unit 76.4265% <ø> (+3.0565%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 86.1714% <ø> (+1.1355%) ⬆️
br 49.9738% <ø> (-2.0584%) ⬇️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

@ywqzzy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@godouxm
Copy link
Contributor

godouxm commented Aug 17, 2023

lgtm

@hawkingrei
Copy link
Member Author

/test all

1 similar comment
@hawkingrei
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-31 08:16:46.419216856 +0000 UTC m=+2001370.968232828: ☑️ agreed by Defined2014.
  • 2023-08-31 08:22:39.790215806 +0000 UTC m=+2001724.339231793: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 7e66761 into pingcap:master Aug 31, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants