Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add bench for MergeGlobalStatsTopNByConcurrency (#45998) #46032

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45998

What problem does this PR solve?

Issue Number: ref #45281

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
$ go test -run=^$ -bench=BenchmarkMergeGlobalStatsTopNByConcurrencyWithHists -benchmem github.com/pingcap/tidb/statistics
goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/statistics
BenchmarkMergeGlobalStatsTopNByConcurrencyWithHists/Size100-8           1000000000               0.0000725 ns/op               0 B/op          0 allocs/op
BenchmarkMergeGlobalStatsTopNByConcurrencyWithHists/Size1000-8          1000000000               0.0006929 ns/op               0 B/op          0 allocs/op
BenchmarkMergeGlobalStatsTopNByConcurrencyWithHists/Size10000-8         1000000000               0.006604 ns/op        0 B/op          0 allocs/op
BenchmarkMergeGlobalStatsTopNByConcurrencyWithHists/Size100000-8        1000000000               0.06678 ns/op         0 B/op          0 allocs/op
BenchmarkMergeGlobalStatsTopNByConcurrencyWithHists/Size1000000-8       1000000000               0.6840 ns/op          0 B/op          0 allocs/op
BenchmarkMergeGlobalStatsTopNByConcurrencyWithHists/Size10000000-8             1        6831699500 ns/op        1680005248 B/op 45000005 allocs/op
BenchmarkMergeGlobalStatsTopNByConcurrencyWithHists/Size100000000-8            1        73070549875 ns/op       16800008416 B/op        450000006 allocs/op

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 13, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 14, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 14, 2023
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hi-rustin,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-14 07:06:20.188212118 +0000 UTC m=+528344.737228105: ☑️ agreed by time-and-fate.
  • 2023-08-14 07:56:15.496464015 +0000 UTC m=+531340.045480002: ☑️ agreed by hi-rustin.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@dfe6238). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46032   +/-   ##
================================================
  Coverage               ?   73.6453%           
================================================
  Files                  ?       1083           
  Lines                  ?     347293           
  Branches               ?          0           
================================================
  Hits                   ?     255765           
  Misses                 ?      75091           
  Partials               ?      16437           

@ti-chi-bot ti-chi-bot bot merged commit 266b833 into pingcap:release-6.5 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants