Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix retChk = nil in index_merge_reader #46111

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #46005

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
@tiprow
Copy link

tiprow bot commented Aug 15, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #46111 (2b2e181) into master (3846e80) will decrease coverage by 1.4827%.
Report is 49 commits behind head on master.
The diff coverage is 85.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46111        +/-   ##
================================================
- Coverage   74.7667%   73.2841%   -1.4827%     
================================================
  Files          1292       1306        +14     
  Lines        398141     405418      +7277     
================================================
- Hits         297677     297107       -570     
- Misses        81100      89853      +8753     
+ Partials      19364      18458       -906     
Flag Coverage Δ
integration 25.8428% <15.0000%> (-20.4201%) ⬇️
unit 73.9643% <85.0000%> (+0.6122%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.2114% <ø> (+0.1457%) ⬆️
br 48.0463% <ø> (-16.4662%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2023
var memUsage int64
var i int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i -> chunkRowOffset ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Aug 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 21, 2023
@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed lgtm labels Aug 21, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-16 08:33:14.987942708 +0000 UTC m=+706359.536958695: ☑️ agreed by wshwsh12.
  • 2023-08-21 06:03:01.126316531 +0000 UTC m=+1129345.675332502: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 533998e into pingcap:master Aug 21, 2023
4 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #46277.

Defined2014 added a commit to ti-chi-bot/tidb that referenced this pull request Aug 21, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@Defined2014 Defined2014 deleted the fix-46005 branch May 31, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb panic for "IndexMergeProcessWorker: runtime error: invalid memory address or nil pointer dereference"
4 participants