Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br/lightning: add duplicate detect adaptor for external writer #46387

Merged
merged 3 commits into from
Aug 24, 2023
Merged

br/lightning: add duplicate detect adaptor for external writer #46387

merged 3 commits into from
Aug 24, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Aug 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #45719

Problem Summary:

What is changed and how it works?

This PR adds duplicate detect adaptor for the writer and refines some test code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2023
@tiprow
Copy link

tiprow bot commented Aug 24, 2023

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wjhuang2016
wjhuang2016 reviewed Aug 24, 2023
View reviewed changes
br/pkg/lightning/backend/external/byte_reader.go
@@ -133,7 +133,6 @@ func (r *byteReader) reload() error {
case io.ErrUnexpectedEOF:
// The last batch.
r.buf = r.buf[:nBytes]
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This break statement is redundant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange that linter didn't find the problem

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance6716,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-24 06:33:26.003488842 +0000 UTC m=+1390370.552504850: ☑️ agreed by wjhuang2016.
  • 2023-08-24 06:37:20.105308854 +0000 UTC m=+1390604.654324840: ☑️ agreed by lance6716.

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Merging #46387 (ed5966e) into master (3352a61) will decrease coverage by 0.6844%.
Report is 4 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46387        +/-   ##
================================================
- Coverage   73.3961%   72.7118%   -0.6844%     
================================================
  Files          1290       1312        +22     
  Lines        393530     399785      +6255     
================================================
+ Hits         288836     290691      +1855     
- Misses        86335      90653      +4318     
- Partials      18359      18441        +82
Flag Coverage Δ
integration 25.6591% <ø> (?)
unit 73.3895% <100.0000%> (-0.0067%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0633% <ø> (ø)
br 47.9451% <100.0000%> (-4.3534%) ⬇️

@tangenta tangenta mentioned this pull request Aug 24, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot merged commit 14745fd into pingcap:master Aug 24, 2023
10 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tangenta @lance6716 @wjhuang2016