Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-go: attach request source with retry info for coprocessor (#46509) #46706

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46509

What problem does this PR solve?

Issue Number: close #46514

Problem Summary:

What is changed and how it works?

Update client-go which will attach the request source with retry info for KV requests. This PR set the required options for coprocessor to enable the extra retry info.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 6, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2023
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 6, 2023
Signed-off-by: you06 <you1474600@gmail.com>
@you06
Copy link
Contributor

you06 commented Sep 6, 2023

/retest

3 similar comments
@you06
Copy link
Contributor

you06 commented Sep 6, 2023

/retest

@you06
Copy link
Contributor

you06 commented Sep 6, 2023

/retest

@you06
Copy link
Contributor

you06 commented Sep 6, 2023

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 6, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 6, 2023
@you06
Copy link
Contributor

you06 commented Sep 6, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-06 11:28:45.204344607 +0000 UTC m=+2531289.753360586: ☑️ agreed by zyguan.
  • 2023-09-07 02:03:37.019586008 +0000 UTC m=+2583781.568601995: ☑️ agreed by hawkingrei.

@you06
Copy link
Contributor

you06 commented Sep 7, 2023

/retest

@you06
Copy link
Contributor

you06 commented Sep 7, 2023

/retest

6 similar comments
@you06
Copy link
Contributor

you06 commented Sep 7, 2023

/retest

@you06
Copy link
Contributor

you06 commented Sep 7, 2023

/retest

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Sep 7, 2023

/retest

@you06
Copy link
Contributor

you06 commented Sep 7, 2023

/retest

@you06
Copy link
Contributor

you06 commented Sep 7, 2023

/retest

@you06
Copy link
Contributor

you06 commented Sep 7, 2023

/retest

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@4350f8d). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46706   +/-   ##
================================================
  Coverage               ?   73.6624%           
================================================
  Files                  ?       1084           
  Lines                  ?     348225           
  Branches               ?          0           
================================================
  Hits                   ?     256511           
  Misses                 ?      75241           
  Partials               ?      16473           

@ti-chi-bot ti-chi-bot bot merged commit cbfa816 into pingcap:release-6.5 Sep 7, 2023
cfzjywxk pushed a commit that referenced this pull request Sep 18, 2023
) (#47003)

* client-go: attach request source with retry info for coprocessor (#46509) (#46706)

close #46514

* restore bazelversiong

Signed-off-by: you06 <you1474600@gmail.com>

* remove unused field

Signed-off-by: you06 <you1474600@gmail.com>

* update client-go

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
…gcap#46706) (pingcap#47003) (pingcap#6)

* client-go: attach request source with retry info for coprocessor (pingcap#46509) (pingcap#46706)

close pingcap#46514

* restore bazelversiong

Signed-off-by: you06 <you1474600@gmail.com>

* remove unused field

Signed-off-by: you06 <you1474600@gmail.com>

* update client-go

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Signed-off-by: you06 <you1474600@gmail.com>
Co-authored-by: you06 <you1474600@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants