Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: change variable tidb_enable_tiflash_pipeline_model to global level #46709

Merged
merged 6 commits into from
Sep 13, 2023
Merged

sessionctx: change variable tidb_enable_tiflash_pipeline_model to global level #46709

merged 6 commits into from
Sep 13, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Sep 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45618 related #45516

Problem Summary:

What is changed and how it works?

  • rename tidb_enable_tiflash_pipeline_model to tiflash_enable_pipeline_model
  • change tiflash_enable_pipeline_model to global level

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@SeaRise SeaRise requested a review from a team as a code owner September 6, 2023 03:36
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2023
@tiprow
Copy link

tiprow bot commented Sep 6, 2023

Hi @SeaRise. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise SeaRise changed the title change variable enable_pipeline to global level change variable tidb_enable_tiflash_pipeline_model to global level Sep 6, 2023
@SeaRise SeaRise changed the title change variable tidb_enable_tiflash_pipeline_model to global level sessionctx: change variable tidb_enable_tiflash_pipeline_model to global level Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #46709 (78413b0) into master (dbb493f) will decrease coverage by 0.1060%.
Report is 23 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46709        +/-   ##
================================================
- Coverage   73.3574%   73.2514%   -0.1060%     
================================================
  Files          1327       1352        +25     
  Lines        396947     408695     +11748     
================================================
+ Hits         291190     299375      +8185     
- Misses        87177      90862      +3685     
+ Partials      18580      18458       -122
Flag Coverage Δ
integration 28.2265% <60.0000%> (?)
unit 73.8615% <100.0000%> (+0.5041%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0052% <ø> (+0.0140%) ⬆️
br 48.9570% <ø> (-3.8303%) ⬇️

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 6, 2023

/cc @XuHuaiyu @windtalker

@ti-chi-bot ti-chi-bot bot requested review from windtalker and XuHuaiyu September 6, 2023 06:47
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 6, 2023

/check_dev_2

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 6, 2023

/run-check_dev_2

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 7, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2023
windtalker
windtalker approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-07 08:19:49.313596623 +0000 UTC m=+2606353.862612605: ☑️ agreed by XuHuaiyu.
  • 2023-09-11 05:26:49.251887066 +0000 UTC m=+246991.176443461: ☑️ agreed by windtalker.

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 11, 2023

/cc @easonn7

@ti-chi-bot ti-chi-bot bot requested a review from easonn7 September 11, 2023 06:14
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 11, 2023

/retest

@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 11, 2023

/test check-dev

@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise SeaRise mentioned this pull request Sep 12, 2023
Merged
12 tasks
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 12, 2023

/test build

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 12, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 12, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Sep 12, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 12, 2023

/test check-dev2

@tiprow
Copy link

tiprow bot commented Sep 12, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@easonn7
Copy link

easonn7 commented Sep 13, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8f8c433 into pingcap:master Sep 13, 2023
@SeaRise SeaRise deleted the gloabl_pipeline_var branch September 13, 2023 05:09
@guo-shaoge guo-shaoge mentioned this pull request Sep 20, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@easonn7 easonn7 Awaiting requested review from easonn7

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set tiflash pipeline model to true by default
4 participants
@SeaRise @easonn7 @windtalker @XuHuaiyu