Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix drop multiple partitions with global index #46908

Conversation

L-maple
Copy link
Contributor

@L-maple L-maple commented Sep 12, 2023

What problem does this PR solve?

Issue Number: close #46907

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

Hi @L-maple. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Sep 12, 2023

Hi @L-maple. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@L-maple
Copy link
Contributor Author

L-maple commented Sep 12, 2023

/cc @mjonss @Defined2014

@ti-chi-bot ti-chi-bot bot requested review from Defined2014 and mjonss September 12, 2023 09:47
@L-maple
Copy link
Contributor Author

L-maple commented Sep 12, 2023

/assign @L-maple

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-12 10:22:15.045958005 +0000 UTC m=+351116.970514395: ☑️ agreed by okJiang.
  • 2023-09-13 15:08:56.501699945 +0000 UTC m=+98102.469287994: ☑️ agreed by mjonss.

@mjonss
Copy link
Contributor

mjonss commented Sep 13, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. do-not-merge/needs-triage-completed labels Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #46908 (a512c27) into master (dc99d14) will decrease coverage by 0.9665%.
Report is 61 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46908        +/-   ##
================================================
- Coverage   73.3549%   72.3884%   -0.9665%     
================================================
  Files          1328       1362        +34     
  Lines        397004     410271     +13267     
================================================
+ Hits         291222     296989      +5767     
- Misses        87190      94497      +7307     
- Partials      18592      18785       +193     
Flag Coverage Δ
integration 30.9646% <ø> (?)
unit 73.1207% <ø> (-0.2343%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (-0.0532%) ⬇️
parser 84.9980% <ø> (-0.0040%) ⬇️
br 48.5605% <ø> (-4.3469%) ⬇️

@mjonss
Copy link
Contributor

mjonss commented Sep 13, 2023

@L-maple could you please try the tests TestDistFrameworkMeta, TestFailSchemaSyncer?
it seems like they are failing (both in CI and on my environment).

@hawkingrei
Copy link
Member

/retest

@L-maple
Copy link
Contributor Author

L-maple commented Sep 14, 2023

@L-maple could you please try the tests TestDistFrameworkMeta, TestFailSchemaSyncer? it seems like they are failing (both in CI and on my environment).

@mjonss
TestDistFrameworkMeta, TestFailSchemaSyncer are ok on my mac and have nothing related with my PR.
image

I see the test TestMemTracker4InsertAndReplaceExec failed in CI. But It seems have nothing related with my PR, and it fails on my previous PR.
image

@okJiang
Copy link
Member

okJiang commented Sep 15, 2023

@L-maple Maybe you can pull the latest code and retest. If you encounter some unstable test cases not related to your pr, you can comment /retest to trigger test again.

@mjonss
Copy link
Contributor

mjonss commented Sep 15, 2023

/retest

@mjonss
Copy link
Contributor

mjonss commented Sep 16, 2023

/retest

@mjonss
Copy link
Contributor

mjonss commented Sep 17, 2023

@L-maple please merge the latest pingcap/master branch, it contains some test updates that is currently failing CI in this branch.

@Defined2014
Copy link
Contributor

/retest-required

@Defined2014
Copy link
Contributor

/test check-dev

@tiprow
Copy link

tiprow bot commented Sep 18, 2023

@Defined2014: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 8d11a2f into pingcap:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ddl: drop multiple partitions for a table with global index causes ddl panic
5 participants