-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix drop multiple partitions with global index #46908
ddl: fix drop multiple partitions with global index #46908
Conversation
Hi @L-maple. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @L-maple. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @mjonss @Defined2014 |
/assign @L-maple |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjonss, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46908 +/- ##
================================================
- Coverage 73.3549% 72.3884% -0.9665%
================================================
Files 1328 1362 +34
Lines 397004 410271 +13267
================================================
+ Hits 291222 296989 +5767
- Misses 87190 94497 +7307
- Partials 18592 18785 +193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@L-maple could you please try the tests TestDistFrameworkMeta, TestFailSchemaSyncer? |
/retest |
@mjonss I see the test TestMemTracker4InsertAndReplaceExec failed in CI. But It seems have nothing related with my PR, and it fails on my previous PR. |
@L-maple Maybe you can pull the latest code and retest. If you encounter some unstable test cases not related to your pr, you can comment |
/retest |
/retest |
@L-maple please merge the latest pingcap/master branch, it contains some test updates that is currently failing CI in this branch. |
/retest-required |
/test check-dev |
@Defined2014: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #46907
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.