-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix recover table by JobID bug when JobID is set to 0 tidb-server panic (#46343) #48087
ddl: fix recover table by JobID bug when JobID is set to 0 tidb-server panic (#46343) #48087
Conversation
/approve |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #48087 +/- ##
================================================
Coverage ? 73.6771%
================================================
Files ? 1404
Lines ? 420444
Branches ? 0
================================================
Hits ? 309771
Misses ? 91404
Partials ? 19269
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, jiyfhust, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
/hold |
/unhold |
/retest |
This is an automated cherry-pick of #46343
What problem does this PR solve?
Issue Number: close #46296
Problem Summary:
The "RECOVER TABLE BY JOB 0":
tidb/executor/ddl.go
Lines 396 to 400 in 8d0fdef
What is changed and how it works?
The both case paser will set JobID to 0, so can't distinguish them by JobID.
Change it by Table info, if it is not nil, it is sql2, else sql1.
case Table is nil and JobID is 0 is impossible.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.