ebs br: make sure fsr credit is full filled (#48627) #48742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
ok-to-test
13 tasks
ti-chi-bot
added
size/L
ti-chi-bot
added
the
cherry-pick-approved
|
/retest |
|
/ok-to-test |
BornChanger
approved these changes
Nov 21, 2023
3pointer
approved these changes
Nov 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #48742 +/- ##
================================================
Coverage ? 73.6406%
================================================
Files ? 1085
Lines ? 349018
Branches ? 0
================================================
Hits ? 257019
Misses ? 75519
Partials ? 16480 |
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
…48742) (pingcap#27) close pingcap#48629 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48627
What problem does this PR solve?
Issue Number: close #48629
Problem Summary:
What is changed and how it works?
Make sure ebs snapshot fsr credit is enough before creating volumes against them. IAM privilege of
cloudwatch:GetMetricStatisticsis required.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.