Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add tidb_analyze_distsql_scan_concurrency #48829

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 23, 2023

What problem does this PR solve?

Issue Number: close #48949

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #48829 (16587c5) into master (334b3ab) will increase coverage by 0.9730%.
Report is 26 commits behind head on master.
The diff coverage is 65.5172%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48829        +/-   ##
================================================
+ Coverage   70.9969%   71.9699%   +0.9730%     
================================================
  Files          1368       1405        +37     
  Lines        403547     416378     +12831     
================================================
+ Hits         286506     299667     +13161     
- Misses        97092      97845       +753     
+ Partials      19949      18866      -1083     
Flag Coverage Δ
integration 43.9386% <65.5172%> (?)
unit 70.9967% <ø> (-0.0003%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.1702% <ø> (-4.8021%) ⬇️

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. do-not-merge/needs-linked-issue size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2023
@hawkingrei hawkingrei removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 28, 2023
@hawkingrei hawkingrei changed the title *: add analyze_dist_sql_scan_concurrency *: add tidb_analyze_distsql_scan_concurrency Nov 28, 2023
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-28 07:18:20.539524319 +0000 UTC m=+907129.204750609: ☑️ agreed by winoros.
  • 2023-11-28 07:30:56.734127523 +0000 UTC m=+907885.399353699: ☑️ agreed by chrysan.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the analyzeDistSQLScanConcurrency branch from 74ab0ab to a2e6dba Compare December 1, 2023 10:14
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

@easonn7
Copy link

easonn7 commented Dec 5, 2023

/approve

Copy link

ti-chi-bot bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrysan, easonn7, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 5, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot merged commit 32cf9b9 into pingcap:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create new variable to control dist_sql_scan_concurrency when to analyze
4 participants