Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR: Support encryption for restored ebs volumes (#48900) #48936

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48900

What problem does this PR solve?

Issue Number: close #48899

Problem Summary:

What changed and how does it work?

This PR adds a new flag "volume-encrypted". The flag sets the encrypted param, when creating the EBS volume. Default is disabled.

The flag will passed as an option to the backup_manager from the restore CRD, which sets it as a flag when invoking restore command.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Naman Gupta <naman.gupta@gmail.com>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@bec245b). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #48936   +/-   ##
================================================
  Coverage               ?   73.6671%           
================================================
  Files                  ?       1087           
  Lines                  ?     349419           
  Branches               ?          0           
================================================
  Hits                   ?     257407           
  Misses                 ?      75514           
  Partials               ?      16498           

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-28 00:44:47.468671825 +0000 UTC m=+883516.133898020: ☑️ agreed by BornChanger.
  • 2023-11-28 01:06:00.249085757 +0000 UTC m=+884788.914311950: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 11ba8f3 into pingcap:release-6.5 Nov 28, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants