-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix some tests failed when system_time_zone != Asia/Shanghai
#49557
Conversation
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49557 +/- ##
================================================
+ Coverage 71.0009% 71.5538% +0.5529%
================================================
Files 1368 1418 +50
Lines 399478 416619 +17141
================================================
+ Hits 283633 298107 +14474
- Misses 96044 99708 +3664
+ Partials 19801 18804 -997
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold Can you remove the timezone config in the bazel config. |
Not fixed all related test cases, I will do it after #49493 closed. |
/unhold |
What problem does this PR solve?
Issue Number: ref #49493
Problem Summary: Deal with
TestTiDBTrx
,TestSetTransactionReadOnlyAsOf
and flashback cluster related problems.Just a workround for flashback cluster related test cases. The root case is #49555.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.