Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor: enable push float down to tikv. #4967

Merged
merged 4 commits into from
Nov 2, 2017

Conversation

winoros
Copy link
Member

@winoros winoros commented Oct 31, 2017

Float constant should be pushed down to tikv.
Actually, all cast sig should be also pushed down to tikv. But there's something to do with error handling.
PTAL @XuHuaiyu @zz-jason @hanfei1991

@shenli
Copy link
Member

shenli commented Oct 31, 2017

Is TiKV able to handle float?

@shenli
Copy link
Member

shenli commented Oct 31, 2017

/run-all-tests

@shenli
Copy link
Member

shenli commented Oct 31, 2017

/cc @BusyJay

@winoros
Copy link
Member Author

winoros commented Nov 1, 2017

/run-all-tests

@BusyJay
Copy link
Contributor

BusyJay commented Nov 1, 2017

Yes, for +, -, *, / operations and abs, ceil, floor functions.

@winoros
Copy link
Member Author

winoros commented Nov 1, 2017

/run-unit-test

@winoros
Copy link
Member Author

winoros commented Nov 1, 2017

The failed case of jenkins' unit test is fixed in #4969 .It failed because test code is not stable enough.

@iamxy
Copy link
Member

iamxy commented Nov 1, 2017

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added this to the 1.1 milestone Nov 2, 2017
@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement. labels Nov 2, 2017
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu merged commit cb08085 into pingcap:master Nov 2, 2017
@winoros winoros deleted the push-down branch November 13, 2017 07:17
winoros added a commit to winoros/tidb that referenced this pull request Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants