-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coprocessor: enable push float down to tikv. #4967
Conversation
Is TiKV able to handle float? |
/run-all-tests |
/cc @BusyJay |
/run-all-tests |
Yes, for +, -, *, / operations and abs, ceil, floor functions. |
/run-unit-test |
The failed case of jenkins' unit test is fixed in #4969 .It failed because test code is not stable enough. |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Float constant should be pushed down to tikv.
Actually, all cast sig should be also pushed down to tikv. But there's something to do with error handling.
PTAL @XuHuaiyu @zz-jason @hanfei1991