-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: remove old regexpBaseFuncSig
and rename regexpNewBaseFuncSig
to regexpBaseFuncSig
#49685
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49685 +/- ##
================================================
+ Coverage 70.9732% 71.4120% +0.4387%
================================================
Files 1368 1424 +56
Lines 398095 415762 +17667
================================================
+ Hits 282541 296904 +14363
- Misses 95813 100067 +4254
+ Partials 19741 18791 -950
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, xzhangxian1008, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #49684
Problem Summary:
After #49584 and #49642 the old
regexpBaseFuncSig
is useless. Now, we can remove it and renameregexpNewBaseFuncSig
toregexpBaseFuncSig
now.What changed and how does it work?
remove old
regexpBaseFuncSig
and renameregexpNewBaseFuncSig
toregexpBaseFuncSig
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.