Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: improve dump.Uintxx implementation #49837

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #44970

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2023
Copy link

tiprow bot commented Dec 27, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #49837 (e647e98) into master (aeefec8) will increase coverage by 0.2546%.
Report is 4 commits behind head on master.
The diff coverage is 66.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49837        +/-   ##
================================================
+ Coverage   70.9200%   71.1747%   +0.2546%     
================================================
  Files          1368       1430        +62     
  Lines        396331     416974     +20643     
================================================
+ Hits         281078     296780     +15702     
- Misses        95564     101359      +5795     
+ Partials      19689      18835       -854     
Flag Coverage Δ
integration 43.7534% <66.6666%> (?)
unit 70.9187% <ø> (-0.0013%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5939% <ø> (-6.3094%) ⬇️

Copy link

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
Copy link

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-27 07:45:29.323932688 +0000 UTC m=+1638220.361159610: ☑️ agreed by hawkingrei.
  • 2023-12-27 09:30:53.445552158 +0000 UTC m=+1644544.482779081: ☑️ agreed by xhebox.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 27, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit cf659a3 into pingcap:master Dec 27, 2023
@Defined2014 Defined2014 deleted the fix-44970 branch December 27, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code clean: refine similar functions in tidb/util/codec and server/internal/dump/dump.go
3 participants