Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindinfo: rename tidb_opt_enable_universal_binding as tidb_opt_enable_fuzzy_binding #50081

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 4, 2024

…_fuzzing_binding

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…_fuzzing_binding

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2024
@hawkingrei hawkingrei changed the title bindinfo: rename tidb_opt_enable_universal_binding as tidb_opt_enable… bindinfo: rename tidb_opt_enable_universal_binding as tidb_opt_enable_fuzzing_binding Jan 4, 2024
@hawkingrei hawkingrei changed the title bindinfo: rename tidb_opt_enable_universal_binding as tidb_opt_enable_fuzzing_binding bindinfo: rename tidb_opt_enable_universal_binding as tidb_opt_enable_fuzzy_binding Jan 4, 2024
…_fuzzing_binding

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #50081 (70ee6c6) into master (6f32664) will increase coverage by 10.0127%.
Report is 4 commits behind head on master.
The diff coverage is 84.6153%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50081         +/-   ##
=================================================
+ Coverage   71.8820%   81.8948%   +10.0127%     
=================================================
  Files          1439       2442       +1003     
  Lines        346160     672907     +326747     
=================================================
+ Hits         248827     551076     +302249     
- Misses        77058     101099      +24041     
- Partials      20275      20732        +457     
Flag Coverage Δ
integration 48.6208% <100.0000%> (?)
unit 79.2478% <84.6153%> (+7.3657%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (+17.3001%) ⬆️
parser ∅ <ø> (∅)
br 71.8492% <ø> (+20.3902%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 4, 2024
@easonn7
Copy link

easonn7 commented Jan 4, 2024

/approve

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 4, 2024
Copy link

ti-chi-bot bot commented Jan 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-04 09:07:34.583032738 +0000 UTC m=+2334345.620259650: ☑️ agreed by qw4990.
  • 2024-01-04 09:13:57.126097082 +0000 UTC m=+2334728.163324010: ☑️ agreed by ywqzzy.

Copy link

ti-chi-bot bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, easonn7, hi-rustin, qw4990, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 8c49f5c into pingcap:master Jan 4, 2024
18 checks passed
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants