-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove stmtctx.BadNullAsWarning
and use errctx
to handle bad null error
#50120
Conversation
c5889bf
to
4a72c05
Compare
4a72c05
to
88efcd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50120 +/- ##
================================================
+ Coverage 79.3235% 82.2241% +2.9005%
================================================
Files 2445 2447 +2
Lines 673463 676986 +3523
================================================
+ Hits 534215 556646 +22431
+ Misses 117881 99721 -18160
+ Partials 21367 20619 -748
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta, XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #50119
What changed and how does it work?
This is one step to move error handling settings from
stmtctx
toerrctx
and this PR:stmtctx.BadNullAsWarning
errctx
to handle bad null errors (with defined as grouperrctx.ErrGroupBadNull
).Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.