Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove stmtctx.BadNullAsWarning and use errctx to handle bad null error #50120

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #50119

What changed and how does it work?

This is one step to move error handling settings from stmtctx to errctx and this PR:

  • remove stmtctx.BadNullAsWarning
  • use errctx to handle bad null errors (with defined as group errctx.ErrGroupBadNull).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2024
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #50120 (88efcd5) into master (17d24f4) will increase coverage by 2.9005%.
Report is 8 commits behind head on master.
The diff coverage is 98.9899%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50120        +/-   ##
================================================
+ Coverage   79.3235%   82.2241%   +2.9005%     
================================================
  Files          2445       2447         +2     
  Lines        673463     676986      +3523     
================================================
+ Hits         534215     556646     +22431     
+ Misses       117881      99721     -18160     
+ Partials      21367      20619       -748     
Flag Coverage Δ
integration 49.4972% <83.9285%> (?)
unit 79.6198% <97.9798%> (+0.2962%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (ø)
parser ∅ <ø> (∅)
br 71.9137% <50.0000%> (+3.4053%) ⬆️

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 06:41:28.636554355 +0000 UTC m=+2411979.673781282: ☑️ agreed by YangKeao.
  • 2024-01-05 09:27:25.428191856 +0000 UTC m=+3435.012445554: ☑️ agreed by tangenta.

Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, XuHuaiyu, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 64741e9 into pingcap:master Jan 5, 2024
12 checks passed
@lcwangchao lcwangchao deleted the errctx_badnull branch January 8, 2024 03:17
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove stmtctx.BadNullAsWarning and use errctx to handle bad null error
5 participants