planner: do not remove the first row func if it is a constant | tidb-test=pr/2277 (#50020) #50283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #50020
What problem does this PR solve?
Issue Number: close #38756
Problem Summary:
What changed and how does it work?
Do not remove the first row func if the group by expr is a constant.
For instance, if you try
SELECT DISTINCT SQRT(1) FROM t
As you can see, we accidentally removed the first-row func because the group by expr is a constant 1 and the arg is also 1.
But if you try
SELECT DISTINCT SQRT(2) FROM t
, it works well.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.