-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: do not remove the first row func if it is a constant #50286
planner: do not remove the first row func if it is a constant #50286
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #50286 +/- ##
================================================
Coverage ? 73.4047%
================================================
Files ? 1209
Lines ? 378835
Branches ? 0
================================================
Hits ? 278083
Misses ? 82985
Partials ? 17767 |
/unhold |
/hold |
This is an automated cherry-pick of #50020
What problem does this PR solve?
Issue Number: close #38756
Problem Summary:
What changed and how does it work?
Do not remove the first row func if the group by expr is a constant.
For instance, if you try
SELECT DISTINCT SQRT(1) FROM t
As you can see, we accidentally removed the first-row func because the group by expr is a constant 1 and the arg is also 1.
But if you try
SELECT DISTINCT SQRT(2) FROM t
, it works well.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.