Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: unlock schema version mutex properly #50327

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jan 11, 2024

What problem does this PR solve?

Issue Number: close #50309

Problem Summary: #50251 missed one line.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2024
Copy link

tiprow bot commented Jan 11, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 08:30:16.148912355 +0000 UTC m=+518405.733166038: ☑️ agreed by ywqzzy.
  • 2024-01-11 08:31:31.393697718 +0000 UTC m=+518480.977951405: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/check-issue-triage-complete

@tangenta tangenta added the priority/P0 The issue has P0 priority. label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Merging #50327 (4d94063) into master (0236944) will decrease coverage by 14.6068%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50327         +/-   ##
=================================================
- Coverage   69.9866%   55.3799%   -14.6068%     
=================================================
  Files          1444       1555        +111     
  Lines        419930     586855     +166925     
=================================================
+ Hits         293895     325000      +31105     
- Misses       105704     239152     +133448     
- Partials      20331      22703       +2372     
Flag Coverage Δ
integration 36.5579% <0.0000%> (?)
unit 69.9962% <100.0000%> (+0.0096%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.5216% <ø> (+5.8707%) ⬆️

Copy link

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, ywqzzy, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit e35bb6d into pingcap:master Jan 11, 2024
22 checks passed
@tangenta tangenta removed the priority/P0 The issue has P0 priority. label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnormal exit in the TestAddIndexIngestRecoverPartition
4 participants