Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: return the complete error info when Parallel Apply meets problem #50335

Merged
merged 5 commits into from
Jan 12, 2024
Merged

planner: return the complete error info when Parallel Apply meets problem #50335

merged 5 commits into from
Jan 12, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 11, 2024 •
edited
Loading

…blem

What problem does this PR solve?

Issue Number: close #50256

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
planner: return the complete error info when Parallel Apply meets pro…
f15ea88 
…blem

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 11, 2024
@hawkingrei
*
e0f043c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
6c2331c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

Merging #50335 (3548ad7) into master (e35bb6d) will decrease coverage by 16.3309%.
Report is 12 commits behind head on master.
The diff coverage is 40.0000%.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #50335         +/-   ##
=================================================
- Coverage   71.8108%   55.4800%   -16.3309%     
=================================================
  Files          1444       1555        +111     
  Lines        346974     587276     +240302     
=================================================
+ Hits         249165     325821      +76656     
- Misses        77476     238689     +161213     
- Partials      20333      22766       +2433
Flag Coverage Δ
integration 36.7144% <40.0000%> (?)
unit 70.0142% <40.0000%> (-1.7966%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (-2.2860%) ⬇️
parser ∅ <ø> (∅)
br 55.4981% <ø> (+4.2076%) ⬆️

@hawkingrei
*
2fda1c5 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2024
@hawkingrei
*
3548ad7 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
elsa0520
elsa0520 reviewed Jan 12, 2024
View reviewed changes
pkg/planner/core/casetest/parallelapply/parallel_apply_test.go
tk.MustExec("create table t3(a int, b int, c int, key(a));")
tk.MustExec("set tidb_enable_parallel_apply=on;")
tk.MustQuery("select (select 1 from t2, t3 where t2.a=t3.a and t2.b > t1.b) from t1;")
tk.MustQuery("show warnings").Check(testkit.Rows("Warning 1105 Some apply operators can not be executed in parallel: *core.PhysicalIndexHashJoin doesn't support cloning"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we do need detailed error information here, wouldn't it be a bad idea to display the object type directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original implementation, ignoring errors could have been a worse design.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 12, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 12, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-12 06:16:16.89065653 +0000 UTC m=+596766.474910213: ☑️ agreed by qw4990.
  • 2024-01-12 09:54:12.873084435 +0000 UTC m=+609842.457338120: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 637aaa5 into pingcap:master Jan 12, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsa0520 elsa0520 elsa0520 left review comments

@AilinKid AilinKid AilinKid approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

planner: display the exact operator name to cause Parallel Apply to not take effect in warnings
4 participants
@hawkingrei @qw4990 @AilinKid @elsa0520